fix: debug test does not output to REPL #112

2025-01-18T00:52:19+03:00

CruelAddict commented

2025-01-18 00:52:19 +03:00

(Migrated from github.com)

Recent changes in nvim-dap behavior required setting outputMode = "remote" in debug configs for stdout to be visible in REPL (see https://github.com/leoluz/nvim-dap-go/issues/108 for more info). The problem is now fixed for test scenarios too.

test_debug now accepts a custom_config argument as a way for users to get around similar problems.

fix #114

Recent changes in nvim-dap behavior required setting `outputMode = "remote"` in debug configs for stdout to be visible in REPL (see https://github.com/leoluz/nvim-dap-go/issues/108 for more info). The problem is now fixed for test scenarios too. `test_debug` now accepts a `custom_config` argument as a way for users to get around similar problems. fix #114

👍 1

lkingland commented

2025-01-27 06:56:09 +03:00

(Migrated from github.com)

Tested; output is now appearing by default in the repl from debug sessions initiated from tests.

@leoluz this seems to be gtg 👍🏻

Tested; output is now appearing by default in the repl from debug sessions initiated from tests. @leoluz this seems to be gtg 👍🏻

leoluz commented

2025-02-03 06:10:46 +03:00

(Migrated from github.com)

Thank you for your contribution.
The new outputMode was already introduced in the plugin by the following PR: https://github.com/leoluz/nvim-dap-go/pull/109
Closing this for now. Please feel free to reopen the PR if you think the issue persists.

Thank you for your contribution. The new outputMode was already introduced in the plugin by the following PR: https://github.com/leoluz/nvim-dap-go/pull/109 Closing this for now. Please feel free to reopen the PR if you think the issue persists.

leoluz commented

2025-02-04 18:07:03 +03:00

(Migrated from github.com)

Sorry.. I misunderstood your PR. Will review it soon.

❤️ 1

leoluz (Migrated from github.com) requested changes

2025-02-08 04:47:47 +03:00

leoluz (Migrated from github.com) left a comment

Tested locally and it works as expected.
Thank you for your contribution.

Tested locally and it works as expected. Thank you for your contribution.

lua/dap-go.lua

					
				@ -234,3 +236,3 @@

				  debug_test(test.name, test.package, M.test_buildflags, extra_args)

				  debug_test(test.name, test.package, M.test_buildflags, extra_args, custom_config)

Adding the custom_config makes it more flexible for supporting future nvim_dap changes. However we need to update the docs to clarify how this works. Please consider updating the doc/nvim-dap-go.txt documenting its usage.

Adding the custom_config makes it more flexible for supporting future nvim_dap changes. However we need to update the docs to clarify how this works. Please consider updating the `doc/nvim-dap-go.txt` documenting its usage.

CruelAddict (Migrated from github.com) reviewed

2025-02-17 23:37:57 +03:00

lua/dap-go.lua

					
				@ -234,3 +236,3 @@

				  debug_test(test.name, test.package, M.test_buildflags, extra_args)

				  debug_test(test.name, test.package, M.test_buildflags, extra_args, custom_config)