Commit graph

24 commits

Author SHA1 Message Date
Samruddhi Khandale
46dfa11ecd
Github cli - Adds retry logic for find git tags (#310)
* Github cli - Adds retry logic for find git tags

* re-add set -e

* address comment
2022-11-30 13:42:57 -08:00
Ilkka Poutanen
173c7ca3c7
Install git before github-cli (#301)
* Install git before github-cli

If building a devcontainer on e.g. `debian:bullseye`, github-cli installation can fail due to git not being installed yet:

```
0 13.38 2022-11-18 13:37:19 (6.08 MB/s) - 'gh_2.20.2_linux_amd64.deb' saved [10
176698/10176698]
#0 13.38
#0 13.40 Selecting previously unselected package gh.
#0 13.41 (Reading database ... 13628 files and directories currently installed.)
#0 13.41 Preparing to unpack .../gh_2.20.2_linux_amd64.deb ...
#0 13.41 Unpacking gh (2.20.2) ...
#0 13.65 dpkg: dependency problems prevent configuration of gh:
#0 13.65  gh depends on git; however:
#0 13.65   Package git is not installed.
#0 13.65
#0 13.65 dpkg: error processing package gh (--install):
#0 13.65  dependency problems - leaving unconfigured
#0 13.66 Errors were encountered while processing:
#0 13.66  gh
#0 13.67 ERROR: Feature "GitHub CLI" (ghcr.io/devcontainers/features/github-cli)
 failed to install! Look at the documentation at https://github.com/devcontainer
s/features/tree/main/src/github-cli for help troubleshooting this error.
```

* bump version

Co-authored-by: Josh Spicer <josh@joshspicer.com>
2022-11-18 10:26:05 -08:00
github-actions[bot]
258b107b39
Automated documentation update (#287)
Automated documentation update [skip ci]

Co-authored-by: github-actions <github-actions@github.com>
2022-11-14 11:40:25 -08:00
Aurelio Jargas
85d2150997
github-cli: Remove duplicated find_version_from_git_tags () (#235)
This function was defined twice in the install script for GitHub CLI, in
old lines 76 and 161. This commit removes the first definition.

The only function calls were on old lines 201 and 222. Since they appear
after the second function definition at line 161, the first one at line
76 never got called, so it's safe to remove it.

I confirmed that this was the only file in this repository where this
function was duplicated:  

    $ git grep '^ *find_version_from_git_tags *('
    src/docker-from-docker/install.sh:find_version_from_git_tags() {
    src/docker-in-docker/install.sh:find_version_from_git_tags() {
    src/git-lfs/install.sh:find_version_from_git_tags() {
    src/github-cli/install.sh:find_version_from_git_tags() {
    src/github-cli/install.sh:find_version_from_git_tags() {
    src/go/install.sh:find_version_from_git_tags() {
    src/kubectl-helm-minikube/install.sh:find_version_from_git_tags() {
    src/php/install.sh:find_version_from_git_tags() {
    src/powershell/install.sh:find_version_from_git_tags() {
    src/python/install.sh:find_version_from_git_tags() {
    src/ruby/install.sh:find_version_from_git_tags() {
    src/rust/install.sh:find_version_from_git_tags() {
    src/terraform/install.sh:find_version_from_git_tags() {
    $
2022-10-28 10:46:16 -07:00
Josh Spicer
67b15cae12
add installsAfter: common-utils to all Features (#214) 2022-10-18 16:30:56 -07:00
github-actions[bot]
530997ce54
Automated documentation update (#218)
Automated documentation update [skip ci]

Co-authored-by: github-actions <github-actions@github.com>
2022-10-13 08:47:25 -07:00
eitsupi
a8cb375d46
Ensure remove apt-update cache at the beginning and end of the scripts (#210)
* remove apt lists

* bump versions
2022-10-10 15:33:01 -07:00
github-actions[bot]
8218a6d3c1
Automated documentation update (#141)
Automated documentation update [skip ci]

Co-authored-by: github-actions <github-actions@github.com>
2022-09-06 16:03:57 -07:00
3x!1
023d623196
Use the newly updated GPG key for GitHub CLI (#139)
* Use the newly updated GPG key for GitHub CLI

* bump feature version
2022-09-06 16:00:39 -07:00
Josh Spicer
7e6dd4b070
download gh cli directly from release (https://github.com/cli/cli/issues/6175) (#133)
* download gh cli release (https://github.com/cli/cli/issues/6175)

* typo

* typo
2022-09-02 17:10:47 -07:00
Josh Spicer
8befe8c114
bump all features to pick up metadata changes in CLI v0.14.0 (#118) 2022-08-26 09:04:54 -07:00
Josh Spicer
41e3e4c748
add documentationURL to all features (#115) 2022-08-24 13:36:05 -04:00
Josh Spicer
0cafeee862
favor correctness by removing apt update ... short-circuiting (#98)
* favor correctness by removing apt update shortciruiting

* Update install.sh

* apt_get_upadate in node

* update test
2022-08-23 09:17:08 -04:00
github-actions[bot]
3ac132483a
Automated documentation update (#106)
Co-authored-by: github-actions <github-actions@github.com>
2022-08-18 12:31:22 -04:00
github-actions[bot]
a8e20a418c
Automated documentation update (#85)
Co-authored-by: github-actions <github-actions@github.com>
2022-08-09 16:08:06 -04:00
Samruddhi Khandale
542963cf04
Prep: republish features to ghcr.io (#78)
* syncing action

* modify release.yaml

* version update ; remove "install"

* add 'latest'

* add workflow condition
2022-08-05 15:22:30 -04:00
Josh Spicer
86eaacb47e Port changes and set executable bit
-Ports change from: https://github.com/microsoft/vscode-dev-containers/pull/1554
Sets all scripts as executable by default.
2022-07-29 15:38:08 +00:00
Devcontainers CI
f03d64feae Automated documentation update 2022-06-22 18:25:18 +00:00
Devcontainers CI
2a51a0164c Automated documentation update 2022-06-21 20:14:53 +00:00
Josh Spicer
3b6fe6e608 add descriptions to feature metadata (no-ci) 2022-06-21 20:14:14 +00:00
Josh Spicer
2fa3232485
Devcontainer docs (#47)
* docs

* automatically generate documentation from features.json

* trigger doc gen

* 1

* no-ci

* no-ci

* no-ci

* no-ci

* comment out pull

* Automated documentation update

* no-ci markdown table

* Automated documentation update

* no-ci

* Automated documentation update

* branch to main

Co-authored-by: Devcontainers CI <vscr-feedback@microsoft.com>
2022-06-13 20:01:19 -04:00
Josh Spicer
c12a205ab8
Pass options via environment variables (#39)
* up to docker-in-docker converted

* first pass at the rest of the features (and bash linting and updated CLI

* move shell linter to own file

* rename feature.json -> devcontainer-feature.json

* continue on error

* continue on error in right spot

* formatting

* fix AZ_VERSION

* update python

* restore variable name

* update linter actions, fix dind/dfd/desktop scripts, add test-scenaerios

* add tree because I like tree

* glob for shell linter

* fix test-scenarios

* shell linter

* more shell helper
2022-06-03 10:46:25 -04:00
Samruddhi Khandale
a7dc1749de
python: bug fix when version = none (#14)
* python: bug fix

* add missing "none" proposal

* nit
2022-05-16 11:05:19 -07:00
Josh Spicer
3a277ad757
restructure and update cli (#11)
* restructure and update cli

* typo
2022-05-12 16:10:51 -04:00