Fix common-utils installation on RHEL (and friends) (#772)
* Fix indentation in common-utils/main.sh * common-utils: Fix install error on RHEL On RHEL (and derivatives) the installation of the common-utils feature could fail if the feature ran before (i.e., `PACKAGES_ALREADY_INSTALLED` is set) and if either `INSTALL_ZSH` is false, or zsh was installed earlier and `ZSH_ALREADY_INSTALLED` is true. In these cases the script the `package_list` is empty, and `dnf` terminates with the following error message: ``` usage: dnf install [-c [config file]] [-q] [-v] [--version] [--installroot [path]] [--nodocs] [--noplugins] [--enableplugin [plugin]] [--disableplugin [plugin]] [--releasever RELEASEVER] [--setopt SETOPTS] [--skip-broken] [-h] [--allowerasing] [-b | --nobest] [-C] [-R [minutes]] [-d [debug level]] [--debugsolver] [--showduplicates] [-e ERRORLEVEL] [--obsoletes] [--rpmverbosity [debug level name]] [-y] [--assumeno] [--enablerepo [repo]] [--disablerepo [repo] | --repo [repo]] [--enable | --disable] [-x [package]] [--disableexcludes [repo]] [--repofrompath [repo,path]] [--noautoremove] [--nogpgcheck] [--color COLOR] [--refresh] [-4] [-6] [--destdir DESTDIR] [--downloadonly] [--comment COMMENT] [--bugfix] [--enhancement] [--newpackage] [--security] [--advisory ADVISORY] [--bz BUGZILLA] [--cve CVES] [--sec-severity {Critical,Important,Moderate,Low}] [--forcearch ARCH] PACKAGE [PACKAGE ...] dnf install: error: the following arguments are required: PACKAGE ``` Fix the problem by running `dnf` only with a non-zero `package_list`.
This commit is contained in:
parent
d53b9d1816
commit
def3a41f57
1 changed files with 8 additions and 6 deletions
|
@ -222,7 +222,9 @@ install_redhat_packages() {
|
|||
package_list="${package_list} zsh"
|
||||
fi
|
||||
|
||||
if [ -n "${package_list}" ]; then
|
||||
${install_cmd} -y install ${package_list}
|
||||
fi
|
||||
|
||||
# Get to latest versions of all packages
|
||||
if [ "${UPGRADE_PACKAGES}" = "true" ]; then
|
||||
|
|
Loading…
Reference in a new issue