NeonXP/features
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

update go tools (#559)

Browse source 
* update go tools

* update link

* add unit tests for confirm installation

* fix path install gotests

* fix bump the minor version
This commit is contained in:
Shunya Hayashi 2023-06-01 00:53:50 +09:00 committed by GitHub
parent b48d8700ff
commit cfae3b0f0d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 23 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/go/devcontainer-feature.json
View file

@ -1,6 +1,6 @@
{ {
"id": "go", "id": "go",
"version": "1.1.3", "version": "1.2.0",
"name": "Go", "name": "Go",
"documentationURL": "https://github.com/devcontainers/features/tree/main/src/go", "documentationURL": "https://github.com/devcontainers/features/tree/main/src/go",
"description": "Installs Go and common Go utilities. Auto-detects latest version and installs needed dependencies.", "description": "Installs Go and common Go utilities. Auto-detects latest version and installs needed dependencies.",

11
src/go/install.sh
View file

@ -191,15 +191,18 @@ else
fi fi
# Install Go tools that are isImportant && !replacedByGopls based on # Install Go tools that are isImportant && !replacedByGopls based on
# https://github.com/golang/vscode-go/blob/v0.31.1/src/goToolsInformation.ts # https://github.com/golang/vscode-go/blob/v0.38.0/src/goToolsInformation.ts
GO_TOOLS="\ GO_TOOLS="\
golang.org/x/tools/gopls@latest \ golang.org/x/tools/gopls@latest \
honnef.co/go/tools/cmd/staticcheck@latest \ honnef.co/go/tools/cmd/staticcheck@latest \
golang.org/x/lint/golint@latest \ golang.org/x/lint/golint@latest \
github.com/mgechev/revive@latest \ github.com/mgechev/revive@latest \
github.com/uudashr/gopkgs/v2/cmd/gopkgs@latest \ github.com/go-delve/delve/cmd/dlv@latest \
github.com/ramya-rao-a/go-outline@latest \ github.com/fatih/gomodifytags@latest \
github.com/go-delve/delve/cmd/dlv@latest" github.com/haya14busa/goplay/cmd/goplay@latest \
github.com/cweill/gotests/gotests@latest \
github.com/josharian/impl@latest"
if [ "${INSTALL_GO_TOOLS}" = "true" ]; then if [ "${INSTALL_GO_TOOLS}" = "true" ]; then
echo "Installing common Go tools..." echo "Installing common Go tools..."
export PATH=${TARGET_GOROOT}/bin:${PATH} export PATH=${TARGET_GOROOT}/bin:${PATH}

15
test/go/test.sh
View file

@ -5,9 +5,24 @@ set -e
# Optional: Import test library # Optional: Import test library
source dev-container-features-test-lib source dev-container-features-test-lib
# go
check "version" go version check "version" go version
# revive
check "revive version" revive --version check "revive version" revive --version
check "revive is installed at correct path" bash -c "which revive | grep /go/bin/revive" check "revive is installed at correct path" bash -c "which revive | grep /go/bin/revive"
# gomodifytags
check "gomodifytags is installed at correct path" bash -c "which gomodifytags | grep /go/bin/gomodifytags"
# goplay
check "goplay is installed at correct path" bash -c "which goplay | grep /go/bin/goplay"
# gotests
check "gotests is installed at correct path" bash -c "which gotests | grep /go/bin/gotests"
# impl
check "impl is installed at correct path" bash -c "which impl | grep /go/bin/impl"
# Report result # Report result
reportResults reportResults